Skip to content

ci: publish github package on successful maven publish#308

Merged
SoulPancake merged 1 commit intomainfrom
ci/publish-gh-req-publish-maven
Mar 17, 2026
Merged

ci: publish github package on successful maven publish#308
SoulPancake merged 1 commit intomainfrom
ci/publish-gh-req-publish-maven

Conversation

@SoulPancake
Copy link
Member

@SoulPancake SoulPancake commented Mar 17, 2026 •
edited by coderabbitai bot
Loading

Description

What problem is being solved?

How is it being solved?

What changes are made to solve it?

References

Review Checklist

  • I have clicked on "allow edits by maintainers".
  • I have added documentation for new/changed functionality in this PR or in a PR to openfga.dev [Provide a link to any relevant PRs in the references section above]
  • The correct base branch is being used, if not main
  • I have added tests to validate that the change in functionality is working as expected

Summary by CodeRabbit

  • Chores
    • Updated GitHub Actions workflow to adjust job sequencing for package publishing processes.

Note: This release contains only internal infrastructure updates with no impact on end-user functionality.

@SoulPancake SoulPancake requested a review from a team as a code owner March 17, 2026 13:25
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 17, 2026 •
edited
Loading

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 488429fb-759a-43ba-94db-2530206696ff

📥 Commits

Reviewing files that changed from the base of the PR and between 1da0dd5 and 3ca8d23.

📒 Files selected for processing (1)
  • .github/workflows/main.yaml

Walkthrough

The GitHub Actions workflow was modified to add an additional job dependency. The publish-github-packages job now requires both the test and publish-maven-central jobs to complete successfully before executing, ensuring Maven Central publication completes prior to GitHub Packages publication.

Changes

Cohort / File(s) Summary
CI/CD Workflow Configuration
.github/workflows/main.yaml		 Extended the needs dependency of publish-github-packages job from [test] to [test, publish-maven-central], establishing sequential job ordering in the publish pipeline.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and specifically describes the main change: adding a dependency to ensure GitHub package publishing waits for successful Maven Central publishing.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch ci/publish-gh-req-publish-maven
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov-commenter
Copy link

codecov-commenter commented Mar 17, 2026 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 38.02%. Comparing base (1da0dd5) to head (3ca8d23).

Additional details and impacted files 
@@            Coverage Diff            @@
##               main     #308   +/-   ##
=========================================
  Coverage     38.02%   38.02%           
  Complexity     1257     1257           
=========================================
  Files           198      198           
  Lines          7643     7643           
  Branches        885      885           
=========================================
  Hits           2906     2906           
  Misses         4598     4598           
  Partials        139      139

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@SoulPancake SoulPancake added this pull request to the merge queue Mar 17, 2026
Merged via the queue into main with commit 9d2fde1 Mar 17, 2026
27 checks passed
@SoulPancake SoulPancake deleted the ci/publish-gh-req-publish-maven branch March 17, 2026 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@curfew-marathon curfew-marathon curfew-marathon approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@SoulPancake @codecov-commenter @curfew-marathon